Update node modules PR check with fixed npm version - #1357
Closed
angelapwen wants to merge 5 commits into
Closed
angelapwen wants to merge 5 commits into
angelapwen wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
reviewed
Nov 10, 2022
Comment thread
.github/workflows/pr-checks.yml
Outdated
3 tasks
angelapwen
marked this pull request as ready for review
November 11, 2022 00:00
aeisenberg
reviewed
Nov 11, 2022
Comment thread
.github/workflows/script/check-node-modules.sh
| if [ ! -z "$(git status --porcelain)" ]; then | ||
| # If we get a fail here then the PR needs attention | ||
| >&2 echo "Failed: node_modules are not up to date. Run 'npm ci && npm run removeNPMAbsolutePaths' on a macOS machine to update. Note it is important this command is run on macOS and not any other operating system as there is one dependency (fsevents) that is needed for macOS and may not be installed if the command is run on a Windows or Linux machine." | ||
| >&2 echo "Failed: node_modules are not up to date. Run 'npm ci && npm run removeNPMAbsolutePaths' on a macOS machine to update and commit. Note it is important this command is run on macOS and not any other operating system as there is one dependency (fsevents) that is needed for macOS and may not be installed if the command is run on a Windows or Linux machine. If there are no changes, run 'npm install --force -g npm@latest' with root permissions first." |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Are we going to pin to v8.19.2? I don't think we can move to package-lock v3 while we also need to support node v12.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The latest v8 release (8.19.3) of npm is compatible with Node 12. I think package-lock v3 should be compatible with Node 12 since the package-lock is only consumed by npm
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closing as this PR check was fixed in #1348 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to always use the latest version of npm in this PR check, but the most recent version of npm would create a different package-lock.json file that causes the PR check to fail. We are unable to update this package-lock.json file because it would not be backwards compatible, so instead we are pinning the PR check to version 8.19.2.
Merge / deployment checklist