TRAP Caching: Re-introduce workaround for download timeout - #1373
Merged
edoardopirovano merged 1 commit intoNov 16, 2022
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
reviewed
Nov 16, 2022
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Since we download trap caches in the init Action, do we need to add await checkForTimeout(); to its entrypoint to prevent things hanging?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Indeed we do, good point. I've amended the PR to do this. |
Sorry, something went wrong.
edoardopirovano
force-pushed
the
edoardo/workaround-download
branch
from
6f663d7 to
bfc5662
Compare
November 16, 2022 15:50
henrymercer
approved these changes
Nov 16, 2022
edoardopirovano
enabled auto-merge
November 16, 2022 17:17
This was referenced Nov 25, 2022
1 task
sfoslund
added a commit
to microsoft/accessibility-insights-web
that referenced
this pull request
Nov 29, 2022
#### Details The codeql action has been timing out in our CI consistently since this weekend. It appears that it's the same issue described in the description of github/codeql-action#1373, so since the work around implemented in that PR has not yet been released, I'm working around it here by just temporarily disabling trap caching. ##### Motivation Work around codeql timeouts #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [n/a] Ran `yarn null:autoadd` - [n/a] Ran `yarn fastpass` - [n/a] Added/updated relevant unit test(s) (and ran `yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at our telemetry, I found a run where the download timeout provided by the Actions library didn't do what we expect. In particular, looking at the timestamps shows that while the downloading happened quickly, the check to see if the key was present in the cache took over 15 minutes (much longer than our 2 minute timeout). Clearly, this is problematic. While it isn't a widespread problem as far as I can see in our telemetry, an outage in the Actions cache could cause this to break all CodeQL runs which is not good.
Let's use our workaround that wraps the entire call in a timeout here too like we already do for uploading.
Merge / deployment checklist