Set testing environment for CodeQL workflow - #1374
Merged
henrymercer merged 4 commits intoNov 16, 2022
Merged
henrymercer merged 4 commits into
henrymercer merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This allows us to set it automatically in the workflow generator, simplifying things and reducing the scope for error.
henrymercer
force-pushed
the
henrymercer/pass-testing-environment
branch
from
1e73af3 to
a836d95
Compare
November 16, 2022 16:40
angelapwen
approved these changes
Nov 16, 2022
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for this, CODEQL_ACTION_TEST_MODE is much clearer to me 👍
Sorry, something went wrong.
3 tasks
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we simply disabled uploading the status reports for all PR checks except ones that were there specifically to test the status report functionality. However when there's a lot of development activity on the CodeQL Action repo and the Actions runtime is being flaky, it's valuable being able to completely exclude CodeQL Action development from telemetry queries.
As drive-by improvements, this PR also makes TEST_MODE specific to the CodeQL Action and enables it in the check-codescanning-config Action. We also remove the INTERNAL_CODEQL_ACTION_DEBUG_LOC variable, which is redundant as of #1358.
Merge / deployment checklist