FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use Swift version 5.7 in PR checks by henrymercer · Pull Request #1387 · github/codeql-action · GitHub

Use Swift version 5.7 in PR checks - #1387

Merged
henrymercer merged 6 commits into
mainfrom
henrymercer/fix-swift-version
Nov 22, 2022
Merged

henrymercer merged 6 commits into
mainfrom
henrymercer/fix-swift-version

Conversation

henrymercer commented Nov 22, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

The version installed in the latest runner image, 5.7.1, is not yet supported.

cc @AlexDenisov

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

The version installed in the latest runner image, 5.7.1, is not yet
supported.
henrymercer force-pushed the henrymercer/fix-swift-version branch from fa52443 to b6e17a6 Compare November 22, 2022 11:31
henrymercer marked this pull request as ready for review November 22, 2022 12:40
henrymercer requested a review from a team as a code owner November 22, 2022 12:40
angelapwen previously approved these changes Nov 22, 2022

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

✔️

I wonder if I should also include this step in the CodeQL Action integration test on the CLI-side (just adding the check for Swift here https://github.com/github/semmle-code/pull/44368/files#)

Copy link
Copy Markdown
Contributor Author

I wonder if I should also include this step in the CodeQL Action integration test on the CLI-side (just adding the check for Swift here https://github.com/github/semmle-code/pull/44368/files#)

👍 That makes sense to me

angelapwen previously approved these changes Nov 22, 2022
henrymercer merged commit def4f60 into main Nov 22, 2022
henrymercer deleted the henrymercer/fix-swift-version branch November 22, 2022 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL