FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove some dead code by henrymercer · Pull Request #1390 · github/codeql-action · GitHub

/ codeql-action Public

Remove some dead code - #1390

Merged
henrymercer merged 2 commits into
mainfrom
henrymercer/remove-dead-code
Nov 23, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Remove some dead code#1390
henrymercer merged 2 commits into
mainfrom
henrymercer/remove-dead-code

Conversation

henrymercer commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

The Action requires GHES 3.3, so we can safely remove this fallback logic for GHES 2.22 and GHES 3.0.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner November 23, 2022 14:04
aeisenberg reviewed Nov 23, 2022
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like GITHUB_ACTION_REPOSITORY is not being set during the integration tests. See:

https://github.com/github/codeql-action/actions/runs/3532744788/jobs/5927496032#step:4:14

aeisenberg commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Otherwise looks reasonable.

henrymercer force-pushed the henrymercer/remove-dead-code branch from d8597f3 to bc341c5 Compare November 23, 2022 18:19

henrymercer commented Nov 23, 2022

Copy link
Copy Markdown
Contributor Author

So GITHUB_ACTION_REPOSITORY is only set when calling an Action from another repository. We still need to populate it manually if we're running locally.

I've updated the PR to only remove the code that deals with the fact that GHES 2.22 didn't populate GITHUB_ACTION_REPOSITORY even when the Action is called from anothe repository.

aeisenberg approved these changes Nov 23, 2022
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM assuming all jobs pass.

henrymercer merged commit 187515b into main Nov 23, 2022
henrymercer deleted the henrymercer/remove-dead-code branch November 23, 2022 18:55
This was referenced Nov 25, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL