python-setup: rely on new virtualenv for venv creation in Ubuntu 22.04 - #1402
Merged
RasmusWL merged 2 commits intoNov 29, 2022
Merged
RasmusWL merged 2 commits into
RasmusWL merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Removes the hotfix from #1257
Copy link
Copy Markdown
Member
Author
|
Forgot to link to the release notes of virtualenv: https://virtualenv.pypa.io/en/latest/changelog.html#bugfixes-20-16-6 -- this was actually fixed some time ago, but apparently my automation for noticing a new release only kicked in for a major release 🤷 |
Sorry, something went wrong.
henrymercer
reviewed
Nov 29, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for following up with the cleanup!
Sorry, something went wrong.
Comment thread
python-setup/install_tools.ps1
Comment thread
python-setup/install_tools.sh
Comment thread
python-setup/install_tools.sh
henrymercer
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the hotfix from #1257
Merge / deployment checklist
Have not updated either, since this should not be a user visible change