FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

python-setup: Handle poetry `virtualenvs.options.no-pip = true` by RasmusWL · Pull Request #1431 · github/codeql-action · GitHub

/ codeql-action Public

python-setup: Handle poetry virtualenvs.options.no-pip = true - #1431

Merged
RasmusWL merged 8 commits into
mainfrom
rasmuswl/poetry-always-install-pip
Jan 16, 2023
ConversationCommits (8)ChecksFiles changed
Merged

python-setup: Handle poetry virtualenvs.options.no-pip = true#1431
RasmusWL merged 8 commits into
mainfrom
rasmuswl/poetry-always-install-pip

Conversation

RasmusWL commented Dec 9, 2022

Copy link
Copy Markdown
Member

Fixes #1425

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg reviewed Dec 9, 2022
View reviewed changes
Comment thread python-setup/find_site_packages.py Outdated
aeisenberg reviewed Dec 12, 2022
View reviewed changes
Comment thread src/analyze.ts
return;
}

const scriptsFolder = path.resolve(__dirname, "../python-setup");

aeisenberg Dec 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You will need to rebuild the javascript files in order to get this to pass.

aeisenberg Dec 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

npm run build

RasmusWL Dec 15, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks <3

RasmusWL force-pushed the rasmuswl/poetry-always-install-pip branch from 0bcae85 to c2e3666 Compare December 15, 2022 14:37

aeisenberg commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Hmmm...at least one of the failing tests may point to a legitimate problem: https://github.com/github/codeql-action/actions/runs/3705092268/jobs/6278570030#step:7:29

RasmusWL force-pushed the rasmuswl/poetry-always-install-pip branch from c2e3666 to 4bd9723 Compare January 13, 2023 10:26
RasmusWL marked this pull request as ready for review January 13, 2023 14:55
RasmusWL requested review from a team as code owners January 13, 2023 14:55

RasmusWL commented Jan 13, 2023

Copy link
Copy Markdown
Member Author

🤔 maybe I should have not rebased, so the old actions runs were still linked from the commits 🤔 anyway, good that the comment from @aeisenberg links directly to the initial windows failure.

Also 🙈 on the fact that it took this many attempts to get it right

aeisenberg approved these changes Jan 13, 2023
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

RasmusWL merged commit 32be38e into main Jan 16, 2023
RasmusWL deleted the rasmuswl/poetry-always-install-pip branch January 16, 2023 08:31
This was referenced Jan 18, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'pip' on github/codeql-action/analyze

2 participants

Back | FazBrowse Home | New Git URL