FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update deprecation notice to state that CodeQL Action v1 is discontinued by henrymercer · Pull Request #1481 · github/codeql-action · GitHub

/ codeql-action Public

Update deprecation notice to state that CodeQL Action v1 is discontinued - #1481

Merged
henrymercer merged 4 commits into
mainfrom
henrymercer/discontinue-v1
Jan 18, 2023
ConversationCommits (4)ChecksFiles changed
Merged

Update deprecation notice to state that CodeQL Action v1 is discontinued#1481
henrymercer merged 4 commits into
mainfrom
henrymercer/discontinue-v1

Conversation

henrymercer commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

For now, link the changelog post announcing the deprecation. However, we expect to publish a new changelog note confirming that the CodeQL Action v1 is now discontinued. Once that's out we should link it from the notice and changelog.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner January 16, 2023 18:43
henrymercer mentioned this pull request Jan 16, 2023
Merged
3 tasks
aeisenberg previously approved these changes Jan 16, 2023
View reviewed changes
Comment thread CHANGELOG.md Outdated
nickfyson previously approved these changes Jan 18, 2023
View reviewed changes

nickfyson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewed changes since last approval

henrymercer enabled auto-merge January 18, 2023 12:28
henrymercer disabled auto-merge January 18, 2023 12:28
aeisenberg reviewed Jan 18, 2023
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/ Give me a 404. I'm guessing this is because it hasn't been released yet, but please make sure this is the right link.

henrymercer commented Jan 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

That's right, this is my guess is to what the URL will be so we can hopefully avoid rerunning the checks and another approval cycle, but the changelog note isn't out yet.

henrymercer commented Jan 18, 2023

Copy link
Copy Markdown
Contributor Author

Changelog post now published.

henrymercer merged commit 597c204 into main Jan 18, 2023
henrymercer deleted the henrymercer/discontinue-v1 branch January 18, 2023 17:24
This was referenced Jan 18, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes
nickfyson nickfyson left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL