Increase strictness of tool caching threshold to avoid caching nightlies - #1496
Merged
henrymercer merged 3 commits intoJan 20, 2023
Merged
Increase strictness of tool caching threshold to avoid caching nightlies#1496henrymercer merged 3 commits into
henrymercer merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
approved these changes
Jan 20, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me~
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the CLI version number of a CodeQL Bundle is a pre-release, then we want to avoid versioning the bundle in the toolcache as <cliVersion>-<bundleVersion>, so we don't interpret this toolcache entry as containing a stable CLI release.
However, we currently version CodeQL nightlies as x.y.z+<timestamp>. Even though these are not pre-releases, we do not want bundles containing them to override CodeQL bundles containing stable versions of the CodeQL CLI.
Therefore this PR ensures we only version bundles as <cliVersion>-<bundleVersion> in the toolcache when cliVersion is of the form x.y.z. All other bundles will be versioned as 0.0.0-<bundleVersion> within the toolcache.
Merge / deployment checklist