Export configuration information to SARIF - #1565
Merged
henrymercer merged 8 commits intoMar 13, 2023
Merged
henrymercer merged 8 commits into
henrymercer merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
force-pushed
the
henrymercer/diagnostics-code-scanning-config
branch
from
9474efa to
4b1f530
Compare
March 7, 2023 21:22
This is more succinct and removes a few line breaks
henrymercer
marked this pull request as ready for review
March 9, 2023 18:44
angelapwen
previously approved these changes
Mar 10, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice!!
Sorry, something went wrong.
angelapwen
approved these changes
Mar 13, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🚢
Sorry, something went wrong.
This was referenced Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exports a configuration information summary to SARIF for green and red runs. This summary comes from the code scanning config file generated by the CLI. When the config is parsed in the Action, nothing will be exported.
We add an integration test exercising the functionality, and gate it behind a feature flag so it is easy to disable if it doesn't behave as expected in the wild.
Merge / deployment checklist