Add override for code scanning analysis of default branch - #1603
charisk merged 1 commit into
Conversation
Sorry, something went wrong.
marcogario
left a comment
There was a problem hiding this comment.
LGTM, but I'd appreciate more 👀
Sorry, something went wrong.
| @@ -630,6 +630,10 @@ function removeRefsHeadsPrefix(ref: string): string { | |||
| // Is the version of the repository we are currently analyzing from the default branch, | |||
| // or alternatively from another branch or a pull request. | |||
There was a problem hiding this comment.
Minor:
// Returns whether we are analyzing the default branch for the repository.
// For cases where the repository information might not be available (e.g., dynamic workflows), this can be forced by the environment variable CODE_SCANNING_IS_ANALYZING_DEFAULT_BRANCH.
Sorry, something went wrong.
henrymercer
left a comment
There was a problem hiding this comment.
Looks good. A minor comment in addition to Marco's doc suggestion.
Sorry, something went wrong.
| process.env["CODE_SCANNING_IS_ANALYZING_DEFAULT_BRANCH"] = "true"; | ||
| t.deepEqual(await actionsutil.isAnalyzingDefaultBranch(), true); | ||
|
|
||
| process.env["CODE_SCANNING_IS_ANALYZING_DEFAULT_BRANCH"] = "false"; |
There was a problem hiding this comment.
Could we move these tests up, or into a separate test function, such that we're testing actionsutil.isAnalyzingDefaultBranch without event.repository.default_branch existing?
Sorry, something went wrong.
henrymercer
left a comment
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
|
Thanks for the reviews! |
Sorry, something went wrong.
Provide an override for code scanning analyses of the default branch.
See internal linked issue for details.
Merge / deployment checklist