Update the sarif schema file - #1668
Merged
aeisenberg merged 5 commits intoMay 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The version we were using is quite old. Copied the latest from https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json I do not think the sarif spec will be changing any more without an explicit version update, so this is fine for now.
aeisenberg
force-pushed
the
aeisenberg/update-sarif-schema
branch
from
9cd82da to
ece3cbc
Compare
May 2, 2023 20:52
Fixes bug in `uniqueItems` property.
Copy link
Copy Markdown
Contributor
Author
|
Oh...that's interesting. The failing check is also failing on main. https://github.com/github/codeql-action/actions/runs/4866066524/jobs/8677165330#step:5:77 There must be some update to the python yaml library we're using. |
Sorry, something went wrong.
adityasharad
reviewed
May 5, 2023
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, couple of minor suggestions. Thanks for catching this.
Sorry, something went wrong.
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
adityasharad
approved these changes
May 5, 2023
Copy link
Copy Markdown
Contributor
Author
|
For reference, this change was made because of a bug in the older version of the sarif schema, as described here: #1230 (comment) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version we were using is quite old. Copied the latest from https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json
I do not think the sarif spec will be changing any more without an explicit version update, so this is fine for now.
Merge / deployment checklist