Avoid throwing validation error on invalid URIs - #1705
Merged
aeisenberg merged 2 commits intoMay 25, 2023
Merged
aeisenberg merged 2 commits into
aeisenberg merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The recent update of jsonschema inadvertently caused extra validation of `uri-reference` formatted properties. This change ensures that these errors are converted to warnings. Note that we cannot revert the change to jsonschema since the old version does not handle `uniqueItems` correctly.
adityasharad
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent update of jsonschema inadvertently caused extra validation of uri-reference formatted properties. This change ensures that these errors are converted to warnings.
Note that we cannot revert the change to jsonschema since the old version does not handle uniqueItems correctly.
Fix for #1703.
Merge / deployment checklist