Remove unused CODESCANNING_EVENT_NAME environment variable - #1712
Merged
henrymercer merged 4 commits intoJun 1, 2023
Merged
henrymercer merged 4 commits into
henrymercer merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
reviewed
May 31, 2023
Comment thread
src/actions-util.ts
Outdated
aeisenberg
approved these changes
May 31, 2023
Copy link
Copy Markdown
Contributor
Author
|
I'll wait until we've done the Swift release before merging this out of an abundance of caution. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Just to be sure: this was never used in a shipped GHES version? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Marco and I went through the default setup templates and we have never used this functionality. |
Sorry, something went wrong.
marcogario
approved these changes
May 31, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This environment variable is not used by default setup, so here we remove the Action's support for it to avoid potential confusion around what workflowEventName() would produce in default setup workflow runs.
Merge / deployment checklist