FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump minimum CodeQL version to 2.9.4 by henrymercer · Pull Request #1724 · github/codeql-action · GitHub

/ codeql-action Public

Bump minimum CodeQL version to 2.9.4 - #1724

Merged
henrymercer merged 10 commits into
mainfrom
henrymercer/bump-minimum-codeql-version
Jul 17, 2023
ConversationCommits (10)ChecksFiles changed
Merged

Bump minimum CodeQL version to 2.9.4#1724
henrymercer merged 10 commits into
mainfrom
henrymercer/bump-minimum-codeql-version

Conversation

henrymercer commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Now that GHES 3.5 is deprecated, we bump the minimum CodeQL version supported by the Action to 2.9.4.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner June 12, 2023 10:40
henrymercer force-pushed the henrymercer/bump-minimum-codeql-version branch from 30ba2dc to b5a2e41 Compare June 12, 2023 11:06
henrymercer force-pushed the henrymercer/bump-minimum-codeql-version branch from 8b03018 to 9f45792 Compare June 12, 2023 12:28
aeisenberg previously approved these changes Jun 12, 2023
View reviewed changes
angelapwen previously approved these changes Jun 14, 2023
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, but I seem to remember that we wanted to improve our communication of bumping the minimum CLI version prior to the Actions release where we deprecate it. I'll backlink the internal issue.

henrymercer commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

The deprecation date for GHES 3.5 changed, so we should hold off on merging this until the new date passes.

henrymercer mentioned this pull request Jul 7, 2023
Merged
henrymercer dismissed stale reviews from angelapwen and aeisenberg via 4149476 July 10, 2023 12:16

henrymercer commented Jul 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I plan to merge this after the CodeQL Action release associated with CodeQL 2.14.0 has completed. We can then wait a week until we release this to give users who are still using the deprecated CLIs time to see the warnings and update.

henrymercer force-pushed the henrymercer/bump-minimum-codeql-version branch from 4149476 to fed4586 Compare July 10, 2023 12:21
henrymercer requested a review from angelapwen July 11, 2023 12:16
angelapwen previously approved these changes Jul 11, 2023
View reviewed changes
henrymercer requested a review from angelapwen July 14, 2023 15:33
henrymercer merged commit 2ff6d83 into main Jul 17, 2023
henrymercer deleted the henrymercer/bump-minimum-codeql-version branch July 17, 2023 12:32
This was referenced Jul 18, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg left review comments
+1 more reviewer
angelapwen angelapwen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL