Skip an API call when downloading a CodeQL version with a semver bundle - #1758
Merged
henrymercer merged 2 commits intoJul 7, 2023
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously, we made an API call to look up the CLI version to release mapping when the default CLI version was requested on Dotcom and that CLI wasn't in the toolcache. Now we compute the tag name directly for semver bundles.
henrymercer
force-pushed
the
henrymercer/bundle-semantic-version-simplifications
branch
from
db2aa0a to
6418c5d
Compare
July 7, 2023 09:59
angelapwen
previously approved these changes
Jul 7, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
✨ great!
Sorry, something went wrong.
Comment thread
src/codeql.ts
Outdated
angelapwen
approved these changes
Jul 7, 2023
henrymercer
enabled auto-merge
July 7, 2023 12:07
henrymercer
deleted the
henrymercer/bundle-semantic-version-simplifications
branch
July 7, 2023 12:22
This was referenced Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we made an API call to look up the CLI version to release mapping when the default CLI version was requested on Dotcom and that CLI wasn't in the toolcache. Now we compute the tag name directly for semver bundles.
Merge / deployment checklist