Scale the amount of reserved RAM on large runners only - #1796
Merged
henrymercer merged 2 commits intoJul 24, 2023
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nickrolfe
approved these changes
Jul 24, 2023
nickrolfe
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks sensible.
Sorry, something went wrong.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially we planned to roll this out to all runners, however we don't currently have the right data to make a decision on the tradeoff between the slowdown and the reduced frequency of OOMs. Therefore, let's roll this out to large runners only where we know the tradeoff is worth it.
This PR also improves the unit tests to check combinations of platform and total RAM without needing to run on different machines. Commit-by-commit review recommended to see examples of the scaling reserved RAM change in the tests.
Merge / deployment checklist