Swap the jest testing framwork for ava - #18
robertbrignull merged 2 commits into
Conversation
Sorry, something went wrong.
|
If I checkout this branch and try to run np run-script test it fails: (node:73266) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time ⠹ (node:73269) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time ⠸ ::debug::Ignoring location URI "/src/foo/bar.js' as it is outside of the src root ⠼ ::debug::Ignoring location URI "/src/foo/bar.js' as it is outside of the src root ::debug::Ignoring location URI "https:///Users/david/github/v2/codeql-action/lib/fingerprints.test.js' as the scheme is not recognised ::debug::Ignoring location URI "ftp:///Users/david/github/v2/codeql-action/lib/fingerprints.test.js' as the scheme is not recognised ::debug::Ignoring location as uri "1" is invalid ::debug::Ignoring location as uri "undefined" is invalid ::debug::Unable to compute fingerprint for non-existent file: /Users/david/github/v2/codeql-action/lib/fingerprints.test.js2 ::debug::Ignoring location as index "1" is invalid ::debug::Ignoring location as index "0" is invalid ⠴ (node:73267) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time ⠋ fingerprints.ts › missingRegions ⠸ analysis-paths.ts › nonEmptyPaths ⠼ analysis-paths.ts › nonEmptyPaths ⠦ external-queries.ts › checkoutExternalQueries 1 test failed external-queries.ts › checkoutExternalQueries Value is not `true`: false |
Sorry, something went wrong.
|
Hmm, they work for me locally, and on actions. What's your nodejs version? I do remember reading something that this requires quite a new version. I'm on v12.16.3. |
Sorry, something went wrong.
|
I'm on v13.8.0 |
Sorry, something went wrong.
|
Hmm, I've just installed v13.14.0 and it works for me. Can you try again and post the error again? If it's a failure in checkoutExternalQueries then it could maybe be something to do you the tmp directory on your machine. |
Sorry, something went wrong.
Daverlo
left a comment
There was a problem hiding this comment.
Now it works for me, I don't know what was the issue but it seems to be resolved
Sorry, something went wrong.
|
Somehow when rebasing to fix conflicts the churn has gone from +102,885 −1,442,871 down to +86,502 −1,442,275. This is all just random noise in the node_modules directory. All my changes to the package.json file are the same. |
Sorry, something went wrong.
Usage of Jest was removed in #18
The main purpose of this is a side project of mine to reduce the number of dependencies we have. It turns out that jest is absolutely humungous. This PR switches it for a more minimal testing framework called ava with no loss of functionality.
Don't get me wrong, jest is quite nice to use, but we don't use anything like its full feature set, so we can switch to a more minimal framework and still be able to do everything we want. I haven't used ava before but it seems reasonable and it's the most lightweight option I've found so far.
Some numbers:
The main change that was necessary to support this is that we need to now compile our test files to javascript before running them, while previousy we could run the typescript "directly" and it would be compiled for us. I think this is fine and it comes with the bonus that our linting rules now apply to our test files, where previously it appears there weren't.
Bonus point, the tests now pass for me locally, while they didn't before and only worked on actions. We used to fail because stuff like @actions/io doesn't work when outside of actions. I haven't 100% worked out why this is now working but I have a hunch it's because we are now compiling our test code to javascript.
To review, I've tried to keep all node_moduldes changes to the first commit, so you can skim through that. All the interesting changes are in the second commit.
Merge / deployment checklist