Add support for the code_scanning_codeql_java_lombok feature flag - #1809
Merged
coadaflorin merged 11 commits intoAug 2, 2023
Merged
coadaflorin merged 11 commits into
coadaflorin merged 11 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
reviewed
Jul 27, 2023
Comment thread
src/feature-flags.ts
Outdated
| { envVar: string; minimumVersion: string | undefined; defaultValue: boolean } | ||
| > = { | ||
| [Feature.CodeqlJavaLombokEnabled]: { | ||
| envVar: "CODEQL_JAVA_LOMBOK_ENABLED", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
For consistency with the others environment variable overrides for the feature flag!
Suggested change
| envVar: "CODEQL_JAVA_LOMBOK_ENABLED", | |
| envVar: "CODEQL_JAVA_LOMBOK", |
Sorry, something went wrong.
angelapwen
previously approved these changes
Jul 27, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
angelapwen
previously approved these changes
Jul 27, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
That should do it 😸
Sorry, something went wrong.
angelapwen
previously approved these changes
Jul 27, 2023
henrymercer
reviewed
Jul 28, 2023
Comment thread
src/init-action.ts
Outdated
henrymercer
previously approved these changes
Jul 28, 2023
henrymercer
approved these changes
Aug 2, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the minimumVersion could be older, but I don't think it's worth the time to work out exactly how old.
Merge / deployment checklist