FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use feature flag to enable evaluator intra-layer parallelism by nickrolfe · Pull Request #1817 · github/codeql-action · GitHub

/ codeql-action Public

Use feature flag to enable evaluator intra-layer parallelism - #1817

Merged
nickrolfe merged 2 commits into
mainfrom
nickrolfe/evaluator-intra-layer-parallelism-ff
Jul 31, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Use feature flag to enable evaluator intra-layer parallelism#1817
nickrolfe merged 2 commits into
mainfrom
nickrolfe/evaluator-intra-layer-parallelism-ff

Conversation

nickrolfe commented Jul 31, 2023 •
edited by angelapwen
Loading

Copy link
Copy Markdown
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

nickrolfe marked this pull request as ready for review July 31, 2023 09:09
nickrolfe requested a review from a team as a code owner July 31, 2023 09:09
angelapwen approved these changes Jul 31, 2023
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me 🎏

nickrolfe merged commit cf445f7 into main Jul 31, 2023
nickrolfe deleted the nickrolfe/evaluator-intra-layer-parallelism-ff branch July 31, 2023 10:03
henrymercer reviewed Jul 31, 2023
View reviewed changes
Comment thread src/codeql.ts
Comment on lines +783 to +790
if (
await features.getValue(
Feature.EvaluatorIntraLayerParallelismEnabled,
this,
)
) {
codeqlArgs.push("--intra-layer-parallelism");
}

henrymercer Jul 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tip for the future: sometimes we may want to disable a feature flag after it's already been enabled by default in the CLI. To do that, we can use a pattern like this where we pass the --no- flag for sufficiently new CLIs when the feature is disabled: https://github.com/github/codeql-action/blob/2f8540dd316af4b6d54b847dba3e67bea2b870e0/src/codeql.ts#L844C1-L851C1.

nickrolfe Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah that's nice, thanks. I'll make a PR to do that.

nickrolfe mentioned this pull request Jul 31, 2023
Merged
3 tasks
github-actions Bot mentioned this pull request Aug 8, 2023
Merged
6 tasks
coderabbitai Bot mentioned this pull request Mar 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

henrymercer henrymercer left review comments
+1 more reviewer
angelapwen angelapwen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL