Add runner disk info and image version to status report - #1825
Merged
henrymercer merged 12 commits intoAug 9, 2023
Merged
henrymercer merged 12 commits into
henrymercer merged 12 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/status-report.test.ts
Fixed
Comment thread
src/status-report.test.ts
Fixed
Comment thread
src/status-report.ts
Fixed
Comment thread
src/status-report.ts
Comment on lines
+291
to
+295
| { | ||
| owner, | ||
| repo, | ||
| data: statusReportJSON, | ||
| }, |
Check warning
Code scanning / CodeQL
File data in outbound network request
angelapwen
previously approved these changes
Aug 8, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Amazing, thank you for all the refactoring and sorting ✨ a couple of questions for my own curiosity!
Sorry, something went wrong.
angelapwen
approved these changes
Aug 9, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good call on the changenote!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds three new fields to the status report:
We also log a warning if there is less than 2 GB of disk space available at various points in the run. For example, we log a warning if there is less than 2 GB of disk available at the start of init, but not at the end of analyze as the user is unlikely to need much space for the rest of the job. For neatness, we only log the warning once per run, but we continue logging the amount of free disk space in the debug logs.
Commit-by-commit review recommended since we do some refactoring, e.g. pulling out status reporting into its own file.
Merge / deployment checklist