FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Lombok: Don't set env var if it's already set by igfoo · Pull Request #1844 · github/codeql-action · GitHub

Lombok: Don't set env var if it's already set - #1844

Merged
igfoo merged 4 commits into
mainfrom
igfoo/lombok_no_overwrite
Aug 18, 2023
Merged

igfoo merged 4 commits into
mainfrom
igfoo/lombok_no_overwrite

Conversation

igfoo commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

If the user has manually configured it, then we let their setting stand.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

igfoo requested a review from a team as a code owner August 18, 2023 11:18
igfoo force-pushed the igfoo/lombok_no_overwrite branch from 3d8058b to b24d125 Compare August 18, 2023 11:25
igfoo force-pushed the igfoo/lombok_no_overwrite branch from b24d125 to c34b59d Compare August 18, 2023 11:31

adityasharad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! One changenote suggestion.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
igfoo merged commit e426271 into main Aug 18, 2023
igfoo deleted the igfoo/lombok_no_overwrite branch August 18, 2023 18:57
github-actions Bot mentioned this pull request Aug 28, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL