Add better error messages when determining merge-base - #1860
Merged
aeisenberg merged 4 commits intoAug 29, 2023
Merged
aeisenberg merged 4 commits into
aeisenberg merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
force-pushed
the
aeisenberg/better-error-messages
branch
6 times, most recently
from
723ff68 to
eb92954
Compare
August 28, 2023 22:35
Avoid printing scary error messages to console when the current directory is not a git repo. Instead provide a better reason for the git failure and continue on.
aeisenberg
force-pushed
the
aeisenberg/better-error-messages
branch
from
eb92954 to
d721f69
Compare
August 28, 2023 22:50
Comment thread
src/actions-util.test.ts
Fixed
henrymercer
reviewed
Aug 29, 2023
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good overall, some minor suggestions. Also I've been suggesting we add changelog notes to more of our PRs and I think this one would benefit from one too.
Sorry, something went wrong.
Comment thread
src/actions-util.test.ts
Outdated
Comment thread
src/actions-util.ts
Outdated
Comment thread
src/actions-util.ts
Outdated
Comment thread
src/actions-util.ts
Outdated
Comment thread
src/actions-util.test.ts
Fixed
Comment thread
src/actions-util.ts
Outdated
henrymercer
previously approved these changes
Aug 29, 2023
Comment thread
src/actions-util.test.ts
Outdated
Comment thread
src/actions-util.test.ts
Outdated
Comment thread
src/actions-util.ts
Outdated
henrymercer
approved these changes
Aug 29, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice, thanks for addressing this bit of customer feedback!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid printing scary error messages to console when the current directory is not a git repo. Instead provide a better reason for the git failure and continue on.
Fixes #1162.
Merge / deployment checklist