Improve logging for Go autobuild when invoked in analyze step - #1862
Merged
angelapwen merged 1 commit intoAug 31, 2023
Merged
angelapwen merged 1 commit into
angelapwen merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
force-pushed
the
add-log-message
branch
from
2bef879 to
d36e2d5
Compare
August 31, 2023 09:44
angelapwen
marked this pull request as ready for review
August 31, 2023 09:44
angelapwen
force-pushed
the
add-log-message
branch
from
d36e2d5 to
ed44103
Compare
August 31, 2023 09:45
angelapwen
force-pushed
the
add-log-message
branch
from
ed44103 to
a0124a7
Compare
August 31, 2023 09:46
MathiasVP
approved these changes
Aug 31, 2023
MathiasVP
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to make it more explicit when we run the Go autobuilder in analyze when the user has not specified the autobuild step. I have used the debug log level (which will show up when re-run on debug mode is activated) rather than info because we have customers on legacy workflows where this is the expected workflow.
Merge / deployment checklist