Enable scaling reserved RAM on GHES - #1866
Merged
henrymercer merged 5 commits intoSep 7, 2023
Merged
henrymercer merged 5 commits into
henrymercer merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
suggested changes
Sep 6, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, just a comment about fixing up the changelog note!
Sorry, something went wrong.
Comment thread
CHANGELOG.md
Outdated
angelapwen
approved these changes
Sep 7, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have completed our experiments with scaling reserved RAM and this feature is now ready to roll out to GHES.
This PR deprecates the feature flag, and also adds an environment variable CODEQL_ACTION_SCALING_RESERVED_RAM_PERCENTAGE. We can use this environment variable to customize the percentage of scaling reserved RAM. Repos can opt out of scaling RAM by setting it to zero, and setting it to any other integer between 1 and 100 lets us fine-tune the RAM calculation.
Merge / deployment checklist