Respect RAM constraints imposed by Linux cgroups - #1888
Merged
henrymercer merged 3 commits intoSep 18, 2023
Merged
henrymercer merged 3 commits into
henrymercer merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
approved these changes
Sep 15, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
NIce! Could we add a comment indicating that once the relevant NodeJS fix is in we'd be able to remove this workaround?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Yes, I'll do so as follow up so I can get this out. |
Sorry, something went wrong.
This was referenced Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Action's RAM calculation to incorporate RAM constraints imposed by Linux cgroups, for example when running in a Docker container on Linux.
We support constraints from both cgroups v1 and v2.
Merge / deployment checklist