C++: introduce automatic installation of dependencies in the autobuilder - #1889
Merged
redsun82 merged 6 commits intoSep 21, 2023
Merged
redsun82 merged 6 commits into
redsun82 merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
redsun82
force-pushed
the
redsun82/cpp-autoinstall-dependencies
branch
from
242362a to
1dc6288
Compare
September 18, 2023 09:00
Comment thread
src/autobuild.ts
Outdated
henrymercer
reviewed
Sep 18, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks like it will do the right thing, though I have a couple of questions about whether we can simplify the experience by reducing the amount of configuration options. Let me know what you think!
Sorry, something went wrong.
Comment thread
autobuild/action.yml
Outdated
Comment thread
src/autobuild.ts
Outdated
Comment thread
src/autobuild.ts
Outdated
Comment thread
src/feature-flags.ts
Comment thread
src/autobuild.ts
Outdated
Comment thread
src/autobuild.ts
Fixed
This introduces the possibility to automatically install dependencies when running the C++ autobuilder on an Ubuntu runner, that will be available with upcoming version 2.15.0. An experimental `cpp-autoinstall-dependencies` input is added to the `autobuild` action. When not set, the default is driven by a feature flag.
redsun82
force-pushed
the
redsun82/cpp-autoinstall-dependencies
branch
from
6de7ce6 to
765807b
Compare
September 20, 2023 12:08
redsun82
marked this pull request as ready for review
September 20, 2023 13:51
henrymercer
previously approved these changes
Sep 21, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Some minor suggestions around logging, but LGTM otherwise!
Sorry, something went wrong.
Comment thread
src/autobuild.ts
Outdated
Comment thread
src/autobuild.ts
Outdated
Comment thread
src/autobuild.ts
Outdated
Co-authored-by: Henry Mercer <henry.mercer@me.com>
redsun82
enabled auto-merge
September 21, 2023 14:11
henrymercer
approved these changes
Sep 21, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Excellent!
Sorry, something went wrong.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the possibility to automatically install dependencies when running the C++ autobuilder on an Ubuntu runner, that will be available with upcoming version 2.15.0. This behaviour can be explicitly requested by setting CODEQL_EXTRACTOR_CPP_AUTOINSTALL_DEPENDENCIES in the autobuild action env, or is otherwise driven by the code_scanning_cpp_dependency_installation feature flag.
Merge / deployment checklist