FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix reading `cgroup` limits on `ubuntu-20.04` by henrymercer · Pull Request #1891 · github/codeql-action · GitHub

/ codeql-action Public

Fix reading cgroup limits on ubuntu-20.04 - #1891

Merged
henrymercer merged 4 commits into
mainfrom
henrymercer/fix-cgroup-limits
Sep 18, 2023
ConversationCommits (4)ChecksFiles changed
Merged

Fix reading cgroup limits on ubuntu-20.04#1891
henrymercer merged 4 commits into
mainfrom
henrymercer/fix-cgroup-limits

Conversation

henrymercer commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix an issue resolving RAM on the ubuntu-20.04 Actions runner image. When running on Ubuntu 20.04, /sys/fs/cgroup/memory/memory.limit_in_bytes sometimes returns MAX_INT to indicate a lack of constraints, which we weren't handling properly.

This PR starts running CodeQL against all supported Actions runner images to ensure that we will catch issues like this in CI in the future.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

github-advanced-security AI commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

henrymercer changed the title Fix cgroup limits Fix reading cgroup limits on ubuntu-20.04 Sep 18, 2023
henrymercer marked this pull request as ready for review September 18, 2023 13:05
henrymercer requested a review from a team as a code owner September 18, 2023 13:05
cklin previously approved these changes Sep 18, 2023
View reviewed changes
Comment thread src/util.ts Outdated
henrymercer requested a review from cklin September 18, 2023 15:10
cklin approved these changes Sep 18, 2023
View reviewed changes

cklin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

henrymercer merged commit f3a128e into main Sep 18, 2023
henrymercer deleted the henrymercer/fix-cgroup-limits branch September 18, 2023 16:25
github-actions Bot mentioned this pull request Sep 19, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cklin cklin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL