Bump min. version for evaluator parallelism feature flag - #1900
Merged
nickrolfe merged 1 commit intoSep 22, 2023
Merged
nickrolfe merged 1 commit into
nickrolfe merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Since we suspect fine-grained parallelism may make the OOM issues worse, we don't want to enable it on 2.14.0-2.14.5, even though they support it.
nickrolfe
marked this pull request as ready for review
September 22, 2023 16:14
aeisenberg
approved these changes
Sep 22, 2023
Copy link
Copy Markdown
Contributor
|
Note that when we ramp up the feature flag, customers pinned to old versions of the CodeQL Action may have fine-grained parallelism enabled despite using an older version of the CLI. This is probably an acceptable risk, given that most customers will be running the up-to-date Action, and running on the older CLI versions will only rarely cause breakage. If we want to be extra cautious, we can rename the feature flag. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Good point, but I agree the risk is low. Fine-grained parallelism should work just fine if it gets enabled on 2.14.0-5. |
Sorry, something went wrong.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we suspect fine-grained parallelism may make the OOM issues worse, we don't want to enable it on 2.14.0-2.14.5, even though they support it.
Merge / deployment checklist