| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Can we already add a feature gate/version flag to that, so that we automatically stop this wrapper script installation at some point in the future? Or a turn-off switch from the CLI? Edit: Maybe we can use the new version feature already? |
Sorry, something went wrong.
There was a problem hiding this comment.
This broadly looks good but still needs some sort of version gating mechanism so that we don't start double-tracing if and when the CLI starts handling this situation for itself.
Sorry, something went wrong.
There was a problem hiding this comment.
As a general comment, are we happy with the test coverage here? Specifically, do we want to add some unit tests or some specific assertions to the PR checks? Or do the existing checks passing on Go 1.21.1 give us enough confidence?
Sorry, something went wrong.
- Change parameter name - Add more documentation
There was a problem hiding this comment.
Thanks, I'd like to hear what Chris thinks about how we should behave in the absence of file, but otherwise this looks good to me.
Sorry, something went wrong.
There was a problem hiding this comment.
Very nice!
Sorry, something went wrong.
Co-authored-by: Henry Mercer <henry.mercer@me.com>
| Back | FazBrowse Home | New Git URL |
This PR modifies the init Action to add a go wrapper script to the PATH if we are running on Linux in order to better cope with tracing builds for Go 1.21 and above. This works as follows:
Additionally, we verify that the result of which go points to our wrapper script in the analyze step by checking it against the value of CODEQL_ACTION_GO_BINARY to make sure that users did not e.g. use a setup-go step after the init action.
Merge / deployment checklist