FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve downloading log message by hoshinotsuyoshi · Pull Request #1920 · github/codeql-action · GitHub

/ codeql-action Public

Improve downloading log message - #1920

Merged
angelapwen merged 1 commit into
github:mainfrom
hoshinotsuyoshi:hoshinotsuyoshi/improve-log-url-in-setup-codeql
Oct 5, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Improve downloading log message#1920
angelapwen merged 1 commit into
github:mainfrom
hoshinotsuyoshi:hoshinotsuyoshi/improve-log-url-in-setup-codeql

Conversation

hoshinotsuyoshi commented Oct 4, 2023 •
edited by angelapwen
Loading

Copy link
Copy Markdown
Contributor

Regarding GitHub Actions log output, the dot was recognized as part of the URL.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

hoshinotsuyoshi marked this pull request as ready for review October 4, 2023 18:43
hoshinotsuyoshi requested a review from a team as a code owner October 4, 2023 18:43
angelapwen reviewed Oct 4, 2023
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for the contribution @hoshinotsuyoshi ✨ You will need to run npm run build in order to regenerate the relevant transpilation files.

Improve downloading log message
6fe4546 
Regarding GitHub Actions log output, the dot was recognized as part of the URL.
hoshinotsuyoshi force-pushed the hoshinotsuyoshi/improve-log-url-in-setup-codeql branch from d9c08be to 6fe4546 Compare October 5, 2023 07:12

hoshinotsuyoshi commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

@angelapwen Thank you! force-pushed 6fe4546 .

angelapwen approved these changes Oct 5, 2023
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! I will turn auto-merge on for when the PR checks pass 🥳

angelapwen enabled auto-merge (squash) October 5, 2023 19:52

aeisenberg commented Oct 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

The failing resolve-environment test recently had some changes. I wonder if something is wrong with the test.

angelapwen commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

I think it should be unrelated as the failure is mv: cannot move 'node_modules' to '../action/node_modules': Permission denied in the prepare step. I'll re-run.

angelapwen merged commit 3f7850a into github:main Oct 5, 2023
github-actions Bot mentioned this pull request Oct 6, 2023
Merged
6 tasks
hoshinotsuyoshi deleted the hoshinotsuyoshi/improve-log-url-in-setup-codeql branch October 10, 2023 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
angelapwen angelapwen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL