Fix using the resolve-environment Action with language aliases - #1923
Merged
henrymercer merged 4 commits intoOct 5, 2023
Merged
henrymercer merged 4 commits into
henrymercer merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This impacted default setup configurations that analyzed Go alongside at least one of the following languages: - C/C++ - Java/Kotlin - JavaScript/TypeScript
henrymercer
force-pushed
the
henrymercer/fix-resolve-environment-aliases
branch
from
a1e37d3 to
66a4d47
Compare
October 5, 2023 14:23
henrymercer
force-pushed
the
henrymercer/fix-resolve-environment-aliases
branch
5 times, most recently
from
ffde0bb to
d2cc101
Compare
October 5, 2023 14:50
henrymercer
force-pushed
the
henrymercer/fix-resolve-environment-aliases
branch
from
d2cc101 to
f243294
Compare
October 5, 2023 14:58
mbg
reviewed
Oct 5, 2023
Comment thread
src/resolve-environment.ts
Outdated
aeisenberg
approved these changes
Oct 5, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that impacted the rollout of language aliases to default setup configurations that analyzed Go alongside at least one of the following languages:
The problem was that while we passed the CLI option to enable language aliasing to resolve languages, we also needed to pass it to resolve build-environment.
We have mitigated this by disabling language aliases in default setup until this fix is out.
Merge / deployment checklist