FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add announcement on Node 16 deprecation by angelapwen · Pull Request #1960 · github/codeql-action · GitHub

Add announcement on Node 16 deprecation - #1960

Merged
angelapwen merged 1 commit into
github:mainfrom
angelapwen:node-16-notice
Oct 18, 2023
Merged

angelapwen merged 1 commit into
github:mainfrom
angelapwen:node-16-notice

Conversation

Copy link
Copy Markdown
Contributor

Make the announcement in the issue visible via the Action changelog and the README.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

angelapwen requested a review from a team as a code owner October 18, 2023 21:19

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good.

One more suggestion. Can we detect when this warning is emitted and emit a second warning pointing to the issue for more information (only if the original warning is also emitted)?

Copy link
Copy Markdown
Contributor Author

Thanks!

One more suggestion. Can we detect when this warning is emitted and emit a second warning pointing to the issue for more information (only if the original warning is also emitted)?

Hm.. that's an interesting idea. I'm not sure actually, I think it will be more clear once the warning is actually emitted. But so far I don't think we've used a mechanism to catch underlying Actions warnings.

Copy link
Copy Markdown
Contributor

After the warning starts being emitted, it will be emitted for every workflow run? If so, we can wait until it's emitted and then include a custom warning that links to the issue.

Copy link
Copy Markdown
Contributor Author

After the warning starts being emitted, it will be emitted for every workflow run? If so, we can wait until it's emitted and then include a custom warning that links to the issue.

Yes, I think so — at least that's what I understood from the Changelog post: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

angelapwen enabled auto-merge (squash) October 18, 2023 21:51
angelapwen merged commit 4a368f6 into github:main Oct 18, 2023
github-actions Bot mentioned this pull request Oct 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL