FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use the correct action input parameter by aeisenberg · Pull Request #1963 · github/codeql-action · GitHub

/ codeql-action Public

Use the correct action input parameter - #1963

Merged
aeisenberg merged 5 commits into
mainfrom
aeisenberg/fix-source-root
Nov 2, 2023
ConversationCommits (5)ChecksFiles changed
Merged

Use the correct action input parameter#1963
aeisenberg merged 5 commits into
mainfrom
aeisenberg/fix-source-root

Conversation

aeisenberg commented Oct 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes an integration test that isn't quite testing what we think it is.

Also, ensures that all macos tests run on python 3.11. See separate commits.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg requested a review from a team as a code owner October 20, 2023 23:15
aeisenberg force-pushed the aeisenberg/fix-source-root branch from ceb945c to 415bca9 Compare October 20, 2023 23:18

angelapwen commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Looks like we're not allowed to remove the current directory in Actions.

aeisenberg commented Oct 21, 2023

Copy link
Copy Markdown
Contributor Author

When I get a chance, I'll selectively remove a few key directories to ensure we're not accidentally using them.

aeisenberg force-pushed the aeisenberg/fix-source-root branch 6 times, most recently from 6eb467f to 2819bc4 Compare November 1, 2023 00:11
aeisenberg force-pushed the aeisenberg/fix-source-root branch from 2819bc4 to da4c460 Compare November 1, 2023 00:16
aeisenberg requested a review from angelapwen November 1, 2023 00:16

aeisenberg commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

@angelapwen can you take another look? I think this should work now.

angelapwen previously approved these changes Nov 1, 2023
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix looks good, but we'll need to fix the Python 3.12 issue causing the tests to fail separately.

angelapwen commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

Re-ran and we got an older version of the runner so PR checks have passed 👍

aeisenberg force-pushed the aeisenberg/fix-source-root branch from 108033a to 8948a7c Compare November 1, 2023 22:50
aeisenberg force-pushed the aeisenberg/fix-source-root branch from 8948a7c to bd4005a Compare November 1, 2023 23:01
angelapwen previously approved these changes Nov 2, 2023
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!! I guess at some point this runner image will stop being macos-latest but looks good for now.

Be more precise about when to use python 3.11
9ef69a2 
Only run use 3.11 on versions of of the CLI that we know don't support
3.12.

aeisenberg commented Nov 2, 2023

Copy link
Copy Markdown
Contributor Author

Updated to only apply python 3.11 for older CLIs. At some point, we can purge references to CLIs we no longer support, but that can happen at some point in the future.

henrymercer previously approved these changes Nov 2, 2023
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Couple of non-blocking suggestions.

Comment thread pr-checks/checks/with-checkout-path.yml Outdated
Comment thread pr-checks/sync.py Outdated
aeisenberg enabled auto-merge November 2, 2023 14:53
auto-merge was automatically disabled November 2, 2023 14:56

Pull Request is not mergeable

aeisenberg enabled auto-merge November 2, 2023 15:04
aeisenberg merged commit 137a1e0 into main Nov 2, 2023
aeisenberg deleted the aeisenberg/fix-source-root branch November 2, 2023 15:18
github-actions Bot mentioned this pull request Nov 14, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

henrymercer henrymercer approved these changes
+1 more reviewer
angelapwen angelapwen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL