C++: add deptrace pr-checks - #1964
Merged
redsun82 merged 7 commits intoOct 25, 2023
Merged
redsun82 merged 7 commits into
redsun82 merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
redsun82
force-pushed
the
redsun82/cpp-deptrace-pr-checks
branch
from
9c3ff35 to
d53a59d
Compare
October 23, 2023 08:58
henrymercer
reviewed
Oct 25, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice! Minor comments and suggestions for clarity, but this looks good!
Sorry, something went wrong.
Comment thread
pr-checks/checks/cpp-deptrace-disabled.yml
Outdated
Comment thread
pr-checks/checks/cpp-deptrace-disabled.yml
Outdated
Comment thread
pr-checks/checks/cpp-deptrace-disabled.yml
Outdated
Comment thread
pr-checks/checks/cpp-deptrace-enabled-on-macos.yml
Outdated
Comment thread
pr-checks/checks/cpp-deptrace-enabled-on-macos.yml
Outdated
Comment thread
pr-checks/checks/cpp-deptrace-enabled.yml
Outdated
Comment thread
pr-checks/checks/cpp-deptrace-enabled.yml
Outdated
Co-authored-by: Henry Mercer <henry.mercer@me.com>
henrymercer
approved these changes
Oct 25, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist