FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable analysis summary v2 and sub-language file coverage information on GHES by henrymercer · Pull Request #1967 · github/codeql-action · GitHub

/ codeql-action Public

Enable analysis summary v2 and sub-language file coverage information on GHES - #1967

Merged
henrymercer merged 8 commits into
mainfrom
henrymercer/enable-features-on-ghes
Oct 27, 2023
ConversationCommits (8)ChecksFiles changed
Merged

Enable analysis summary v2 and sub-language file coverage information on GHES#1967
henrymercer merged 8 commits into
mainfrom
henrymercer/enable-features-on-ghes

Conversation

henrymercer commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

This PR:

  • Enables analysis summary v2 on GHES 3.9 and later (since the new summary currently links to the status page unconditionally).
  • Enables sub-language file coverage information on the upcoming GHES 3.12 and later.
  • Cleans up the feature flag for exporting failed SARIF.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner October 25, 2023 18:53
aeisenberg reviewed Oct 25, 2023
View reviewed changes
Comment thread src/codeql.ts
Comment thread src/feature-flags.ts
angelapwen previously approved these changes Oct 26, 2023
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thanks for the 🧹 cleanup on failed SARIF too!

henrymercer commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

Now I get an opportunity to use #1971 :)

henrymercer added the Rebuild Re-transpile JS & re-generate workflows label Oct 26, 2023
github-actions Bot removed the Rebuild Re-transpile JS & re-generate workflows label Oct 26, 2023

henrymercer commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

Well, I'm not too surprised that didn't work. Pushing a fix.

angelapwen commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Ah.. I'd also thought that it'd check out the current branch by default, but it does make sense that the checkout action isn't aware of the current branch ref.

henrymercer enabled auto-merge October 26, 2023 19:02

henrymercer commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

Ah.. I'd also thought that it'd check out the current branch by default, but it does make sense that the checkout action isn't aware of the current branch ref.

I think it checks out the synthetic merge commit vs the head of the branch, and the latter is what we want to push to.

henrymercer merged commit 14d0fa9 into main Oct 27, 2023
henrymercer deleted the henrymercer/enable-features-on-ghes branch October 27, 2023 08:29
github-actions Bot mentioned this pull request Oct 27, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes
+1 more reviewer
angelapwen angelapwen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL