Add pre-commit configuration - #1969
Merged
redsun82 merged 1 commit intoOct 26, 2023
Merged
redsun82 merged 1 commit into
redsun82 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
[pre-commit](https://pre-commit.com/) is a framework for easy set-up of pre-commit hooks. This adds configuration for it to run: * ts compilation * ts linting * pr-checks synchronization The latter required the `sync.py` to be callable from the project root. `pre-commit` can be enabled with ``` python3 -m pip install pre-commit pre-commit install ```
henrymercer
approved these changes
Oct 26, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks good. It isn't for me, as it makes committing take too long, but I'm happy to approve it.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
yeah, it's true I was a bit hesitant about the linting check (the other two are pretty much instant if compilation was already done). On the other hand for me that I don't work so often here, I was already bitten by committing something not passing all three of the checks 😅 FYI there is a way to tweak the configuration locally. |
Sorry, something went wrong.
6 tasks
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit is a framework for easy set-up of pre-commit hooks.
This adds configuration for it to run:
The latter required the sync.py to be callable from the project root.
pre-commit can be enabled with
Merge / deployment checklist