FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Validate workflow within new log group by henrymercer · Pull Request #1970 · github/codeql-action · GitHub

Validate workflow within new log group - #1970

Merged
henrymercer merged 2 commits into
mainfrom
henrymercer/clean-up-init-logs
Oct 27, 2023
Merged

henrymercer merged 2 commits into
mainfrom
henrymercer/clean-up-init-logs

Conversation

Copy link
Copy Markdown
Contributor

This cleans up the logs for init.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

This cleans up the logs for `init`.
henrymercer requested a review from a team as a code owner October 26, 2023 10:17
angelapwen previously approved these changes Oct 26, 2023

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🚢

angelapwen commented Oct 26, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Although this seems to come out empty — I wonder if that's confusing to users? Does it need to run in debug mode to actually show something in the group?

Copy link
Copy Markdown
Contributor Author

Although this seems to come out empty — I wonder if that's confusing to users? Does it need to run in debug mode to actually show something in the group?

Our test workflows are a little unusual since they don't have the typical languages matrix configuration. Therefore we're not seeing the CodeQL CLI logs for codeql resolve languages, since that validation isn't being called.

I think the best way to address this is to add a log that no issues were detected.

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good 👍

henrymercer enabled auto-merge October 26, 2023 19:01
henrymercer disabled auto-merge October 26, 2023 19:13
henrymercer merged commit 2d5ffa7 into main Oct 27, 2023
henrymercer deleted the henrymercer/clean-up-init-logs branch October 27, 2023 08:32
github-actions Bot mentioned this pull request Oct 27, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL