update release process to support multiple version - #2014
Merged
nickfyson merged 9 commits intoDec 7, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
reviewed
Dec 5, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good! My main comment is around what happens the first time we backport a new major version of the Action.
Sorry, something went wrong.
Comment thread
.github/actions/release-branches/release-branches.py
Outdated
Comment thread
.github/actions/release-branches/release-branches.py
Comment thread
.github/actions/release-initialise/action.yml
Outdated
Comment thread
.github/update-release-branch.py
Outdated
Comment thread
.github/update-release-branch.py
Outdated
Comment thread
.github/workflows/post-release-mergeback.yml
Outdated
Comment thread
CONTRIBUTING.md
Outdated
Comment thread
CONTRIBUTING.md
Outdated
Comment thread
CONTRIBUTING.md
Outdated
Comment thread
.github/workflows/update-release-branch.yml
Outdated
Co-authored-by: Henry Mercer <henry.mercer@me.com>
henrymercer
approved these changes
Dec 6, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Excellent, thanks for addressing my comments!
Sorry, something went wrong.
This was referenced Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR udpates the release process in order to handle maintaining multiple versions. To a large extent this reintroduces the logic removed in...
...but adapted in order to avoid hardcoding version numbers. The process should also support maintaining two or more older version of the action, should that ever be required.
The process to release a new version will now be to first bump the major version number and merge that PR to main. Then run the update-release-branch.yml workflow, which will...
Note that both these workflows will also be triggered when mergeback PRs are merged against older release branches, but in this case update-release-branch.yml will take no action and update-release-branch.yml will run only the operations to ensure tags for the relevant version are up to date.
Retiring older versions is now a matter of updating OLDEST_SUPPORTED_MAJOR_VERSION in release-branches.py, see the new section in CONTRIBUTING.md for details.
NB The changes in this PR have been tested in a private fork of the repository.
Merge / deployment checklist