FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Python: Don't install deps by default for all users by RasmusWL · Pull Request #2031 · github/codeql-action · GitHub

/ codeql-action Public

Python: Don't install deps by default for all users - #2031

Merged
RasmusWL merged 14 commits into
mainfrom
rasmuswl/no-dep-inst-default
Jan 5, 2024
ConversationCommits (14)ChecksFiles changed
Merged

Python: Don't install deps by default for all users#2031
RasmusWL merged 14 commits into
mainfrom
rasmuswl/no-dep-inst-default

Conversation

RasmusWL commented Dec 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

RasmusWL commented Dec 13, 2023

Copy link
Copy Markdown
Member Author

I think we can ignore Swift analysis using a custom build command as a spurious failure 😊

aeisenberg reviewed Dec 13, 2023
View reviewed changes
Comment thread CHANGELOG.md Outdated

aeisenberg commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

LGTM! I'll avoid approving this until you move this out of draft mode.

RasmusWL marked this pull request as ready for review January 4, 2024 15:08
RasmusWL requested a review from a team as a code owner January 4, 2024 15:08
RasmusWL requested a review from henrymercer January 4, 2024 15:08
henrymercer reviewed Jan 4, 2024
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks great, just a couple of comments.

Comment thread src/analyze.ts Outdated
Comment thread CHANGELOG.md

## [UNRELEASED]

- We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting `CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false` in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. [#2031](https://github.com/github/codeql-action/pull/2031)

henrymercer Jan 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

[Non-blocking] Currently we disable Python dependency installation for CodeQL v2.16.0 and later, however the Action supports CodeQL versions all the way back to 2.11.6. Do we plan to keep supporting Python dependency installation for old CLIs in the Action until support for v2.15.5 is deprecated in about a year from now?

RasmusWL Jan 5, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I had hoped to be able delete the python-setup folder and all the logic for dependency installation soon, but let's discuss this aspect some more 👍

henrymercer Jan 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 We can always start applying this to earlier CLI versions later on. Happy to discuss!

Comment thread src/init-action.ts
RasmusWL requested a review from henrymercer January 5, 2024 09:24
henrymercer approved these changes Jan 5, 2024
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great, thank you! FYI, if after pushing commits you realize that you forgot to rebuild the Action, you can now apply the "Rebuild" label to have Actions rebuild it for you.

RasmusWL merged commit 58ff74a into main Jan 5, 2024
RasmusWL deleted the rasmuswl/no-dep-inst-default branch January 5, 2024 10:18
github-actions Bot mentioned this pull request Jan 8, 2024
Merged
8 tasks
This was referenced Jan 8, 2024
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg left review comments
henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL