update required checks script to handle release branches - #2050
Merged
nickfyson merged 2 commits intoDec 20, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
3 tasks
nickfyson
force-pushed
the
nickfyson/add-releases-ini
branch
from
eb558b3 to
a42c9a2
Compare
December 20, 2023 17:23
nickfyson
marked this pull request as ready for review
December 20, 2023 17:23
aeisenberg
previously approved these changes
Dec 20, 2023
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice work with the bash script.
Sorry, something went wrong.
aeisenberg
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the definition of OLDEST_SUPPORTED_MAJOR_VERSION to a config file, and sources it both from the action that determines release branches and the script to update required checks.
Merge / deployment checklist