Remove config parsing logic that is now implemented in the CLI - #2062
Merged
henrymercer merged 10 commits intoJan 5, 2024
Merged
henrymercer merged 10 commits into
henrymercer merged 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
previously approved these changes
Jan 4, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Whew, I think I 👀 d all the changes — looks so much cleaner now! I assume the status report changes will be a follow-up?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
There are two aspects to the status report changes:
|
Sorry, something went wrong.
angelapwen
approved these changes
Jan 5, 2024
8 tasks
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CodeQL CLI v2.11.6, we finished implementing key parts of parsing the code scanning configuration within the CLI. This enabled this functionality to be used by folks running code scanning using a third-party CI system.
However due to the need to support earlier versions of the CLI that do not support config parsing, we have needed to duplicate config parsing code between the Action and the CLI.
Now that CodeQL CLI v2.11.5 and earlier have been deprecated, we can remove this legacy config parsing code from the Action.
Merge / deployment checklist