FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clean up running queries some more by henrymercer · Pull Request #2065 · github/codeql-action · GitHub

Clean up running queries some more - #2065

Merged
henrymercer merged 1 commit into
mainfrom
henrymercer/further-run-queries-cleanup
Jan 8, 2024
Merged

henrymercer merged 1 commit into
mainfrom
henrymercer/further-run-queries-cleanup

Conversation

Copy link
Copy Markdown
Contributor

Now that we have deprecated parsing the configuration in the Action, we can simplify running queries to reflect that:

  • We will run all the queries for a language in one group, so we can always pass --expect-discarded-cache.
  • We no longer specify query suites when running queries, so we can delete the logic for doing this. Instead the query suite is stored within the database.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner January 5, 2024 19:13

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 looks good to me!

henrymercer merged commit fd55bb0 into main Jan 8, 2024
henrymercer deleted the henrymercer/further-run-queries-cleanup branch January 8, 2024 11:11
github-actions Bot mentioned this pull request Jan 8, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL