Python: disable dependency installation on GHES - #2106
Merged
RasmusWL merged 4 commits intoFeb 1, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
As announced in https://github.blog/changelog/2024-01-23-codeql-2-16-python-dependency-installation-disabled-new-queries-and-bug-fixes/ we have turned on this feature flag for github.com already. This change ensures that users on GHES also has this feature enabled by default.
henrymercer
previously approved these changes
Jan 30, 2024
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, just a small suggestion for the changelog note for consistency.
Sorry, something went wrong.
Comment thread
CHANGELOG.md
Outdated
Co-authored-by: Henry Mercer <henrymercer@github.com>
Copy link
Copy Markdown
Member
Author
thanks ❤️ |
Sorry, something went wrong.
angelapwen
approved these changes
Feb 1, 2024
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After succesfully rolling out this change to all customers on github.com (see https://github.blog/changelog/2024-01-23-codeql-2-16-python-dependency-installation-disabled-new-queries-and-bug-fixes/), this PR will ensure it is also disabled for new GHES releases.
Merge / deployment checklist