Add experimental build-mode input - #2108
Merged
henrymercer merged 7 commits intoFeb 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is a slightly simpler API
henrymercer
force-pushed
the
henrymercer/build-mode-input
branch
from
c1e0768 to
463930c
Compare
January 31, 2024 14:55
aeisenberg
previously approved these changes
Jan 31, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think the action iput description can be clarified, but it's not a blocking change.
Sorry, something went wrong.
Comment thread
init/action.yml
aeisenberg
approved these changes
Feb 1, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
angelapwen
approved these changes
Feb 2, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🆒 😄
Sorry, something went wrong.
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an experimental build-mode input to the init Action. This is currently for internal testing only.
We forward this input to codeql database init and add a test to check that the build mode is forwarded to the database as expected, and Java buildless extraction completes successfully.
This PR makes use of the config refactoring implemented in #2107.
Merge / deployment checklist