FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Telemetry: Handle failures determining disk usage by henrymercer · Pull Request #2112 · github/codeql-action · GitHub

/ codeql-action Public

Telemetry: Handle failures determining disk usage - #2112

Merged
henrymercer merged 1 commit into
mainfrom
henrymercer/status-report-handle-disk-failures
Feb 2, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Telemetry: Handle failures determining disk usage#2112
henrymercer merged 1 commit into
mainfrom
henrymercer/status-report-handle-disk-failures

Conversation

henrymercer commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

We've noticed some situations where df fails due to the tracer not initializing correctly, and therefore we are unable to determine available disk space. Let's instead fail gracefully when we can't determine available disk space.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner February 2, 2024 17:09
aeisenberg approved these changes Feb 2, 2024
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My comment shouldn't block having this merged, but something to add later if we want.

Comment thread src/status-report.ts
Comment on lines +243 to +244
statusReport.runner_available_disk_space_bytes = diskInfo.numAvailableBytes;
statusReport.runner_total_disk_space_bytes = diskInfo.numTotalBytes;

aeisenberg Feb 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we want to capture the reason for the df failure and send it as part of the status report?

aeisenberg Feb 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The message wouldn't make it into kusto, but at least it would be available in splunk.

henrymercer Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We could probably add an internal error diagnostic for this. Let's address as potential follow up, as you suggest.

henrymercer enabled auto-merge February 2, 2024 17:13
henrymercer merged commit 2db0327 into main Feb 2, 2024
henrymercer deleted the henrymercer/status-report-handle-disk-failures branch February 2, 2024 17:31
This was referenced Feb 2, 2024
Merged
Merged
aeisenberg mentioned this pull request Feb 6, 2024
Open
ginsbach mentioned this pull request Jul 11, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL