FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow omitting the autobuild Action when build mode specified by henrymercer · Pull Request #2120 · github/codeql-action · GitHub

/ codeql-action Public

Allow omitting the autobuild Action when build mode specified - #2120

Merged
henrymercer merged 5 commits into
mainfrom
henrymercer/no-autobuild-action-necessary-with-build-mode
Feb 8, 2024
ConversationCommits (5)ChecksFiles changed
Merged

Allow omitting the autobuild Action when build mode specified #2120
henrymercer merged 5 commits into
mainfrom
henrymercer/no-autobuild-action-necessary-with-build-mode

Conversation

henrymercer commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

This PR enables users to omit the autobuild Action when the build mode is specified and the CLI supports the traceCommandUseBuildMode feature (available in CodeQL CLI 2.16.2 and later). This will remove redundancy and reduce the possibility for errors.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner February 7, 2024 13:31
angelapwen previously approved these changes Feb 7, 2024
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cool! I like how simple that test was 💖

Comment thread src/analyze.ts
henrymercer force-pushed the henrymercer/no-autobuild-action-necessary-with-build-mode branch from 3bd00e8 to f3ced61 Compare February 8, 2024 16:00

henrymercer commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

@angelapwen I added a couple more tests for the other build modes. Would you mind taking another look?

angelapwen approved these changes Feb 8, 2024
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The new tests look good to me! Should this have a changelog note? Or will we wait for a general larger-scale announcement of the new build modes?

henrymercer commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

Right now, this is just for internal testing. Once we've finished testing, we can remove all the internal labels and add a changelog note with all the changes.

henrymercer enabled auto-merge February 8, 2024 16:16
henrymercer merged commit fc9f9e5 into main Feb 8, 2024
henrymercer deleted the henrymercer/no-autobuild-action-necessary-with-build-mode branch February 8, 2024 16:23
github-actions Bot mentioned this pull request Feb 13, 2024
Merged
8 tasks
henrymercer mentioned this pull request Feb 13, 2024
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
angelapwen angelapwen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL