FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Treat status reports as non-critical by jsoref · Pull Request #2121 · github/codeql-action · GitHub

/ codeql-action Public

Treat status reports as non-critical - #2121

Merged
aeisenberg merged 1 commit into
github:mainfrom
jsoref:status-reports-are-not-critical
Feb 12, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Treat status reports as non-critical#2121
aeisenberg merged 1 commit into
github:mainfrom
jsoref:status-reports-are-not-critical

Conversation

jsoref commented Feb 8, 2024 •
edited by angelapwen
Loading

Copy link
Copy Markdown
Contributor

Resolve github/codeql#15462 (comment) by converting sendStatusReport into a function that always returns void and uses core.warning instead of core.error

Split from:

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

jsoref requested a review from a team as a code owner February 8, 2024 03:09
jsoref mentioned this pull request Feb 8, 2024
Merged
angelapwen reviewed Feb 8, 2024
View reviewed changes

angelapwen left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks again for this — our telemetry reporting should indeed be non-critical! I've just added a few comments.

I think this may warrant a CHANGELOG entry 🌞 users who may have seen this failure in the past should be happy to see the change.

Comment thread src/upload-lib.ts
Comment thread src/upload-lib.ts Outdated
ffried mentioned this pull request Feb 8, 2024
Open
jsoref force-pushed the status-reports-are-not-critical branch 2 times, most recently from 6145d06 to d3f9862 Compare February 8, 2024 19:05
jsoref requested a review from angelapwen February 8, 2024 19:07
This was referenced Feb 8, 2024
Open
Open
aeisenberg reviewed Feb 9, 2024
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is looking great. I have a few copy-editing suggestions and one question about 404/403 errors.

Comment thread package.json Outdated
Comment thread src/status-report.ts Outdated
Comment thread src/status-report.ts Outdated
Comment thread src/upload-lib.ts Outdated
Comment thread src/upload-lib.ts Outdated
Comment thread CHANGELOG.md Outdated
jsoref force-pushed the status-reports-are-not-critical branch from ac030dd to 5942183 Compare February 9, 2024 21:02
aeisenberg previously approved these changes Feb 9, 2024
View reviewed changes
Comment thread src/upload-lib.ts
import { SarifFile, ConfigurationError, wrapError } from "./util";

const GENERIC_403_MSG =
"The repo on which this action is running has not opted-in to CodeQL code scanning.";

aeisenberg Feb 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This message and the one below it needs some work, but as you mentioned, it is outside the scope of this PR.

aeisenberg commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

Thanks again for your work on this.

jsoref commented Feb 12, 2024
View reviewed changes
Comment thread src/status-report.ts Outdated
aeisenberg previously approved these changes Feb 12, 2024
View reviewed changes
aeisenberg enabled auto-merge February 12, 2024 18:41
aeisenberg disabled auto-merge February 12, 2024 18:41
Treat status reports as non-critical
5a6da1d 
Change `sendStatusReport` to `void`
jsoref force-pushed the status-reports-are-not-critical branch from df25046 to 5a6da1d Compare February 12, 2024 18:56
jsoref requested a review from aeisenberg February 12, 2024 18:56
aeisenberg merged commit 4075abf into github:main Feb 12, 2024

aeisenberg commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

Thanks again! Nice work here.

jsoref deleted the status-reports-are-not-critical branch February 12, 2024 21:07
github-actions Bot mentioned this pull request Feb 13, 2024
Merged
8 tasks
henrymercer mentioned this pull request Feb 13, 2024
Merged
13 tasks
This was referenced May 13, 2024
Open
Open
This was referenced May 14, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes
angelapwen Awaiting requested review from angelapwen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Workflows are missing permissions requests

3 participants

Back | FazBrowse Home | New Git URL