Stop running debug artifacts checks on MacOS - #2123
Merged
angelapwen merged 1 commit intoFeb 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
marked this pull request as ready for review
February 8, 2024 17:13
angelapwen
enabled auto-merge (squash)
February 8, 2024 17:37
aeisenberg
approved these changes
Feb 9, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor suggestion, but this looks good.
Sorry, something went wrong.
Comment thread
.github/workflows/debug-artifacts-failure.yml
| fi | ||
| done | ||
| popd | ||
| pushd "./my-debug-artifacts" |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
No longer need pushd/popd since there's only one directory now.
Suggested change
| pushd "./my-debug-artifacts" | |
| cd "./my-debug-artifacts" |
Sorry, something went wrong.
Comment thread
.github/workflows/debug-artifacts-failure.yml
| exit 1 | ||
| fi | ||
| done | ||
| popd |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| popd |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry, I'd set this to auto-merge and it merged as soon as you approved 😆 |
Sorry, something went wrong.
angelapwen
added a commit
to angelapwen/codeql-action
that referenced
this pull request
Feb 13, 2024
Suggested in github#2123 but was automerged before I could apply the suggestion
8 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These checks take a while, and there's no specific reason to run them on MacOS in particular. We run them only on ubuntu-latest instead.
Merge / deployment checklist