Avoid analyzing generated configuration file - #2135
Merged
henrymercer merged 1 commit intoFeb 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This prevents it from becoming part of the analysis.
angelapwen
approved these changes
Feb 13, 2024
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks fine, though do we expect the config file to affect the analysis in some way if it's not in the temp directory?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Since it's a YAML file it'll be included in JavaScript extraction by default. I noticed when I was trying to create a "no code found" error, but despite no JS or YAML being in the repository, the JavaScript analysis successfully extracted the configuration file and therefore didn't error. |
Sorry, something went wrong.
8 tasks
This was referenced Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the generated config file in temporary directory to prevent it from becoming part of the analysis.
Merge / deployment checklist